Skip to content

Explain how to add license server access to SpeosRPC docker container creation #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 12, 2022
Merged

Explain how to add license server access to SpeosRPC docker container creation #30

merged 8 commits into from
Aug 12, 2022

Conversation

echambla
Copy link
Collaborator

@echambla echambla commented Aug 11, 2022 •
edited
Loading

In this PR:

  • use LICENSE_SERVER env variable in docker-compose file
  • This env var can be used by both user directly (explained in README) or by CI/CD (coming from a secret)
  • Add a check of running server befor launching all tests

@github-actions github-actions bot added maintenance Package and maintenance related CI/CD enhancement New features or code improvements labels Aug 11, 2022
@github-actions github-actions bot added CI/CD and removed CI/CD labels Aug 11, 2022
@github-actions github-actions bot added CI/CD and removed CI/CD labels Aug 11, 2022
@github-actions github-actions bot added CI/CD and removed CI/CD labels Aug 11, 2022
@github-actions github-actions bot added CI/CD and removed CI/CD labels Aug 11, 2022
@github-actions github-actions bot added CI/CD and removed CI/CD labels Aug 11, 2022
@github-actions github-actions bot added CI/CD and removed CI/CD labels Aug 11, 2022
@echambla echambla changed the title Use secret to have license server access Explain how to add license server access to SpeosRPC docker container creation Aug 11, 2022
@github-actions github-actions bot added CI/CD and removed CI/CD labels Aug 11, 2022
@echambla echambla merged commit e744599 into main Aug 12, 2022
@echambla echambla deleted the feat/licenseServerAccess_dockerContainer branch August 12, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgonzalezacevedo bgonzalezacevedo bgonzalezacevedo approved these changes

@jomadec jomadec jomadec approved these changes

@etiennearnal etiennearnal Awaiting requested review from etiennearnal

@Revathyvenugopal162 Revathyvenugopal162 Awaiting requested review from Revathyvenugopal162

Assignees
No one assigned
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@echambla @bgonzalezacevedo @jomadec